Include a py.typed marker file with the Python client#100
Open
isomorpheme wants to merge 1 commit intomasterfrom
Open
Include a py.typed marker file with the Python client#100isomorpheme wants to merge 1 commit intomasterfrom
py.typed marker file with the Python client#100isomorpheme wants to merge 1 commit intomasterfrom
Conversation
Contributor
Author
|
I've created #101 as a possible followup step. |
isomorpheme
commented
Apr 24, 2026
| features = ["pyo3/extension-module"] | ||
| python-source = "python" | ||
| module-name = "opsqueue.opsqueue_internal" | ||
| include = ["**/py.typed"] |
Contributor
Author
There was a problem hiding this comment.
I don't know how to check if this does what I expect it to; I don't know how to inspect the results of just build-python. Would appreciate pointers!
Contributor
Author
There was a problem hiding this comment.
It didn't per se, but I figured it out: just build-python builds a wheel in /tmp and cleans it up before finishing, so instead I used maturin build which outputs it locally. It turns out that .whl files are secretly just zip archives, so I checked and the py.typed is indeed included. 🎉
Qqwy
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8. I've checked that the
py.typedfile is included when building via Nix, and then usingreveal_typeonProducerClient.get_submission_statuschanges mypy reportinginto
So this doesn't entirely make types available, due to PyO3/pyo3#5137, but it improves the situation.